Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43656 )
Change subject: device/cardbus: Check for NULL
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43656/2/src/device/cardbus_device.c
File src/device/cardbus_device.c:
https://review.coreboot.org/c/coreboot/+/43656/2/src/device/cardbus_device.c...
PS2, Line 147: PCI_BRIDGE_CTL_BUS_RESET));
Nit, I would prefer braces around this.
https://review.coreboot.org/c/coreboot/+/43656/2/src/device/cardbus_device.c...
PS2, Line 149: printk(BIOS_ERR, "cardbus: dev->link_list is NULL\n");
I'd return here.
And skip the working code below? Most of all, not enable needed resources?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43656
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f62229e6870897544b45d44278380bb5820416b
Gerrit-Change-Number: 43656
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 20 Jul 2020 22:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment