Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40538 )
Change subject: tests: Add lib/string-test test case ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40538/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40538/1//COMMIT_MSG@20 PS1, Line 20: make unit-tests Here's what I get:
$ make unit-tests * * Restart config... * * * General setup * Local version string (LOCALVERSION) [] (NEW)
and it's waiting for me to answer all the config questions. Was there a missing step?
https://review.coreboot.org/c/coreboot/+/40538/1//COMMIT_MSG@13 PS1, Line 13: In order to run this example, one need to install (beside general : coreboot dependencies) cmocka package: : sudo apt-get install -y libcmocka-dev : sudo emerge dev-util/cmocka : yum install libcmocka-devel : : After invoking: : make unit-tests : report from unit test will be created and shown on the screen Change this to a TEST= line, such as TEST=Install cmocka via appropriate command: * sudo apt-get install -y libcmocka-dev * sudo emerge dev-util/cmocka * yum install libcmocka-devel Build and run unit tests via `make unit-tests` Check the output to see that tests passed.
https://review.coreboot.org/c/coreboot/+/40538/1//COMMIT_MSG@23 PS1, Line 23: This test harness definitely isn't complete, as it only checks for some : functions within module. Purpose of this code is only an example and a : starting point for a discussion about implementation. : You don't need to explain this; the first paragraph already says this is a basic example.