[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC contr...

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 )

Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller
......................................................................

Patch Set 3:
> Patch Set 2:
> > Patch Set 2:
> >
> > @Arthur/Patrick R: Do you care to take -1 back?
>
> So you somehow need to manually sync this Kconfig option with the devicetree in which the eMMC controller gets disabled too? If so my -1 stays here. If you somehow really don't want this ACPI code to be included when the device is disabled, generate it on runtime like told before or put it in a different file and don't include DSDT but yet another Kconfig option does not seem like a good solution.

Having another ASL still does not absolve us of keeping in-sync 2 things. in this approach we would have keep the devicetree and ASL (DSDT) in sync.