Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Eric Lai.
Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI
......................................................................
Patch Set 12:
(2 comments)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/66992/comment/3f8e4d15_92b3e237
PS10, Line 424: /* B11 : [] ==> EN_FP_PWR */
For constiency, can we clean up the names in the comments […]
Done
https://review.coreboot.org/c/coreboot/+/66992/comment/2fd26e39_5cbeb5db
PS10, Line 426: /* C23 : [] ==> FP_RST_ODL */
I know I said earlier today to put these into romstage. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e6be24e72a8232ae2c958a01cf8ea9a272d7365
Gerrit-Change-Number: 66992
Gerrit-PatchSet: 12
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 20 Sep 2022 22:29:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Gerrit-MessageType: comment