Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38184 )
Change subject: drivers/pc80/rtc: Enable normal/fallback without USE_OPTION_TABLE
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38184/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38184/4//COMMIT_MSG@9
PS4, Line 9: Due the !USE_OPTION_TABLE it always booted to fallback.
Squash it into the other commit adding the if condition?
This is functional change, the other one was just refactoring.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38184
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44eb50df4389d1ac9e4c746f53654aff1055d400
Gerrit-Change-Number: 38184
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Jan 2020 08:21:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment