Edward O'Callaghan (eocallaghan@alterapraxis.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/5437
-gerrit
commit 17c7c70d5ee761a0652876545fc108bf91d58300 Author: Edward O'Callaghan eocallaghan@alterapraxis.com Date: Mon Mar 31 15:14:14 2014 +1100
superio/fintek/f71889: [4/4] Avoid .c includes
Following the same reasoning as commit d3043313a91dff3bc2f879ffb3b4bf23a364d711 superio/fintek/f81865f: Avoid .c includes Clean up the early_serial #include directives in mainboard/romstage code.
Change-Id: Id8a1a2e8c87add636af1506598c2669d72dc3238 Signed-off-by: Edward O'Callaghan eocallaghan@alterapraxis.com --- src/superio/fintek/f71889/Makefile.inc | 2 +- src/superio/fintek/f71889/chip.h | 2 +- src/superio/fintek/f71889/early_serial.c | 2 +- src/superio/fintek/f71889/f71889.h | 4 +++- 4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/superio/fintek/f71889/Makefile.inc b/src/superio/fintek/f71889/Makefile.inc index ef14b74..9864140 100644 --- a/src/superio/fintek/f71889/Makefile.inc +++ b/src/superio/fintek/f71889/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ##
+romstage-$(CONFIG_SUPERIO_FINTEK_F71889) += early_serial.c ramstage-$(CONFIG_SUPERIO_FINTEK_F71889) += superio.c - diff --git a/src/superio/fintek/f71889/chip.h b/src/superio/fintek/f71889/chip.h index 2895efc..50312ad 100644 --- a/src/superio/fintek/f71889/chip.h +++ b/src/superio/fintek/f71889/chip.h @@ -29,4 +29,4 @@ struct superio_fintek_f71889_config { struct pc_keyboard keyboard; };
-#endif +#endif /* SUPERIO_FINTEK_F71889_CHIP_H */ diff --git a/src/superio/fintek/f71889/early_serial.c b/src/superio/fintek/f71889/early_serial.c index 9623cbd..7ab8946 100644 --- a/src/superio/fintek/f71889/early_serial.c +++ b/src/superio/fintek/f71889/early_serial.c @@ -35,7 +35,7 @@ static void pnp_exit_conf_state(device_t dev) outb(0xaa, port); }
-static void f71889_enable_serial(device_t dev, u16 iobase) +void f71889_enable_serial(device_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/fintek/f71889/f71889.h b/src/superio/fintek/f71889/f71889.h index 1b6a369..6dc43b3 100644 --- a/src/superio/fintek/f71889/f71889.h +++ b/src/superio/fintek/f71889/f71889.h @@ -34,4 +34,6 @@ #define F71889_PME 0x0a /* Power Management Events (PME) and ACPI */ #define F71889_VREF 0x0b /* Vref */
-#endif +void f71889_enable_serial(device_t dev, u16 iobase); + +#endif /* SUPERIO_FINTEK_F71889_F71889_H */