Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40729 )
Change subject: soc/intel/gma: Implement fsp_soc_get_igd_bar() in common code
......................................................................
Patch Set 4:
Patch Set 4:
does it make sense to delete graphics.c for platforms which don't yet implement intel_igd_get_controller_info() but likely will, or which don't yet have soc-specific panel init yet?
Nothing is soc specific. Intel copy-paste hardware designs just
like software. I assume the SKL panel init also works up to CML.
The one for APL might work everywhere else.
I have plans to move intel_igd_get_controller_info() into `chip.c`.
Need a break, though ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40729
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa5981088eeb5c36f765d6332ae47a38a6a4c875
Gerrit-Change-Number: 40729
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 26 Apr 2020 20:06:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment