Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39872 )
Change subject: mb/google/cyan: Clean up Kconfig ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39872/1/src/mainboard/google/cyan/K... File src/mainboard/google/cyan/Kconfig:
https://review.coreboot.org/c/coreboot/+/39872/1/src/mainboard/google/cyan/K... PS1, Line 85: config VGA_BIOS_ID : string : depends on VGA_BIOS : default "8086,22b0" : help : The VGA_BIOS_ID for the C0 version of the video BIOS is hardcoded : in soc/intel/braswell/Makefile.inc as 8086,22b1 Why drop this? it's still correct for people that have (extracted) the blob?
https://review.coreboot.org/c/coreboot/+/39872/1/src/mainboard/google/cyan/K... PS1, Line 86: default y if ENABLE_BUILTIN_COM1 If I wanted to enable the serial console, I would probably look in the "Console" menu... so how about inverting this:
config CONSOLE_SERIAL default n
config ENABLE_BUILTIN_COM1 default y if CONSOLE_SERIAL
That would leave us with a spurious DRIVERS_UART_8250IO in the default config, but it shouldn't hurt I guess.