Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43750 )
Change subject: mb/google/dedede/var/madoo: Configure USB port setting for Madoo
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43750/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43750/1/src/mainboard/google/dedede...
PS1, Line 56: chip drivers/usb/acpi
: register "desc" = ""Integrated Bluetooth""
: register "type" = "UPC_TYPE_INTERNAL"
: register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)"
: device usb 2.7 on end
: end
This is the same as baseboard configuration. So no need to override it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia73593f52adee3806e725127891f084a08bf1360
Gerrit-Change-Number: 43750
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 24 Jul 2020 08:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment