Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35110 )
Change subject: soc/mediatek/mt8183: Run DRAM full calibration ......................................................................
Patch Set 53:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... File src/mainboard/google/kukui/romstage.c:
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 28: CALIBRATION_REGION
Please add a comment above: […]
Done
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 32: CALIBRATION_REGION
does this really work? can you temporarily set REGION_SIZE to a smaller size and check? […]
Yes I tested it before.
src/mainboard/google/kukui/romstage.c:32:1: error: static assertion failed: "sizeof(struct dramc_param) exceeds RW_DDR_TRAINING
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 37: (void *)
I wonder if we really need to do this cast? (void * should be converted automatically?)
Cast removed.
https://review.coreboot.org/c/coreboot/+/35110/52/src/mainboard/google/kukui... PS52, Line 47: (void *)
const void *
Cast removed.