build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63475 )
Change subject: cpu/x86/smm_module_loader.c: Rewrite setup more purely function ......................................................................
Patch Set 1:
(8 comments)
File src/cpu/x86/smm/smm_module_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/a0ef45a6_5e002d05 PS1, Line 468: const uintptr_t handler_base = ALIGN_DOWN(fx_save_area_base - handler_size, handler_alignment); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/bc3917e0_aadf2b1d PS1, Line 469: printk(BIOS_DEBUG, "smihandler [0x%lx-0x%lx[\n", handler_base, handler_base + handler_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/dbf338b0_ac8ba0d7 PS1, Line 515: return smm_module_setup_stub(stub_segment_base, smram_size, params, (void *)fx_save_area_base); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/1933f0ed_ad94f267 PS1, Line 561: const uintptr_t save_state_bottom = cpus[params->num_concurrent_save_states - 1].ss_start; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/c7c970f4_d155776a PS1, Line 569: printk(BIOS_ERR, "fxsave wont fit in smram\n"); 'wont' may be misspelled - perhaps 'won't'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/2fef056b_8a1e8dbc PS1, Line 574: const size_t bottom_space = cpus[params->num_concurrent_save_states - 1].code_start - smm_stack_top; line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/4642e83d_39389172 PS1, Line 583: printk(BIOS_ERR, "handler wont fit in top of smram\n"); 'wont' may be misspelled - perhaps 'won't'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145792): https://review.coreboot.org/c/coreboot/+/63475/comment/4ca6a36c_1f43fc96 PS1, Line 590: printk(BIOS_ERR, "handler wont fit in bottom of smram\n"); 'wont' may be misspelled - perhaps 'won't'?