[coreboot-gerrit] Change in coreboot[master]: vendorcode/google: load sar config from CBFS first then VPD

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33661 )

Change subject: vendorcode/google: load sar config from CBFS first then VPD
......................................................................

Patch Set 1:
> Patch Set 1:
> > > Quick question: Do we want to still continue supporting SAR in VPD?
> >
> > It'd certainly be simpler to just require CBFS.
>
> My suggestion is yes and the reason is to reduce the dependency to the FW (no necessary to up-rev FW). And after SAR value is reviewed, factory test can still verify the value.

In my opinion, having 2 ways of doing things makes it confusing for the partners. If we are moving towards CBFS, ideally, it would be good to encourage partners to start using that. For the factory test, partners can still use CBFS SAR without having to rebuild the whole image. It would require few additional steps, but we can definitely come up with steps for them. What do you think?