[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add northbridge pci driver

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )

Change subject: soc/amd/picasso: Add northbridge pci driver
......................................................................

Patch Set 31:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
PS31, Line 41: for (; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) {
I don't think we should be adding these separately. This is already handled by the FSP driver by ensuring that the HOBs get placed in reserved CBMEM area. But, I think there is a bug to fix this later?

https://review.coreboot.org/c/coreboot/+/34424/31/src/soc/amd/picasso/northb... 
PS31, Line 69: pscope
acpi_device_scope(device) instead?