[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/braswell/pmutil.c: Use GEN_PMCON1 for RTC status

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32724 )

Change subject: soc/intel/braswell/pmutil.c:  Use GEN_PMCON1 for RTC status
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32724/1/src/soc/intel/braswell/pmutil.c 
File src/soc/intel/braswell/pmutil.c:

https://review.coreboot.org/#/c/32724/1/src/soc/intel/braswell/pmutil.c@367 
PS1, Line 367: 	gen_pmcon1 = read32((u32 *)(PMC_BASE_ADDRESS + GEN_PMCON1));
> rtc_failure() is called by car_soc_post_console_init() and vbnv_cmos_failed(). […]

Hmm, in that case, we could also drop the cbmem_find() as you did and
try to blacklist this function in ramstage. e.g.

#include <assert.h>

/* not usable in ramstage as GEN_PMCON1 gets reset */
    if (ENV_RAMSTAGE)
            dead_code();

Your call.