Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36012 )
Change subject: [WIP] drivers/usb/xhci-dbc: Add USB3 Dbc
......................................................................
Patch Set 27:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36012/27/src/drivers/usb/xhci-dbc.c
File src/drivers/usb/xhci-dbc.c:
https://review.coreboot.org/c/coreboot/+/36012/27/src/drivers/usb/xhci-dbc.c...
PS27, Line 818: void __iomem *base = 0;
That should be PCI BAR0 resource start
https://review.coreboot.org/c/coreboot/+/36012/27/src/drivers/usb/xhci-dbc.c...
PS27, Line 836: offset = xhci_find_next_ext_cap(xdbc.xhci_base, 0, XHCI_EXT_CAPS_DEBUG);
why do search for something on NULL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36012
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67ab1792184cba46ef09ee944866c1ca5b810d7c
Gerrit-Change-Number: 36012
Gerrit-PatchSet: 27
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 18 Nov 2019 12:15:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment