build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38256 )
Change subject: [WIP]soc/intel/common/block: Add EMMC dll caching infrastructure ......................................................................
Patch Set 8:
(11 comments)
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... File src/soc/intel/common/block/scs/emmc_cache.c:
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 45: bool is_tuning_success; please, no space before tabs
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 196: stored_emmc_data = (struct mmc_dll_params*) data; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 276: return (void*)md; "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 300: // stuct emmc_tuned_values emmc_data; 'stuct' may be misspelled - perhaps 'struct'?
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 302: void* data_file; "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 351: if ((tuning_succeed == true)|| (tuning_succeed == -1)) { spaces required around that '||' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 352: printk(BIOS_ERR, "EMMC: calling tuning algo \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 355: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 370: if (region_file_update_data(&cache_file, data_file,size) < 0) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 376: else { else should follow close brace '}'
https://review.coreboot.org/c/coreboot/+/38256/8/src/soc/intel/common/block/... PS8, Line 384: } void function return statements are not generally useful