Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47602 )
Change subject: [WIP] arch/x86: Use intermediate .id section
......................................................................
Patch Set 1:
Now I wonder, could we turn it around? let `version.c` point to
the strings in `id.S`. Would that make things easier? assuming
the goal is to get rid of the duplication.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47602
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35d3312336e9c66d657d2ca619cf30fd79e18fd4
Gerrit-Change-Number: 47602
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 22:41:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment