Attention is currently required from: Julius Werner, Yu-Ping Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74317 )
Change subject: util/cbfstool: Add "Comp" column for "print -k"
......................................................................
Patch Set 1:
(1 comment)
File util/cbfstool/cbfs_image.c:
https://review.coreboot.org/c/coreboot/+/74317/comment/4b1f15e9_646756ab
PS1, Line 1535: const char *compression_name = lookup_name_by_type(
should we still keep the guard? if(compression != CBFS_COMPRESS_NONE)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3e23c58662fb7b9c5d704de93e2df28957528d
Gerrit-Change-Number: 74317
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 08:26:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment