30 Nov
2021
30 Nov
'21
10:40 p.m.
Attention is currently required from: Felix Held, Rajat Jain. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59730 )
Change subject: drivers/gfx/generic: Add optional _HID for gfx devices ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/gfx/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/59730/comment/f18bb37e_386c2266 PS1, Line 125: acpigen_write_name_integer("_STA", 0xF);
is it intended that the device status information gets removed?
Nope, that was a mistake, good eye Felix!
--
To view, visit https://review.coreboot.org/c/coreboot/+/59730
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32be4abf5c60be1f94aabaa2e9c734215c4e291e
Gerrit-Change-Number: 59730
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Rajat Jain rajatja@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Rajat Jain rajatja@google.com
Gerrit-Comment-Date: Tue, 30 Nov 2021 22:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment