Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39271 )
Change subject: mb/google/hatch: Add LP_4G_2133 SPD
......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG@7
PS5, Line 7: for Nightfury
Remove this. This is not specific to a particular variant. […]
Done
https://review.coreboot.org/c/coreboot/+/39271/5//COMMIT_MSG@9
PS5, Line 9: for Nightfury.
Same here.
Done
https://review.coreboot.org/c/coreboot/+/39271/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/nightfury/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39271/5/src/mainboard/google/hatch/...
PS5, Line 17: SPD_SOURCES += LP_4G_2133 # 0b010
Let's move this into https://review.coreboot. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39271
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1598774a87eecc76082286540beadaa3c26eda69
Gerrit-Change-Number: 39271
Gerrit-PatchSet: 8
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@chromium.org
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 11 Mar 2020 14:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment