Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37594 )
Change subject: libpayload/drivers/i8042: Add AT translated Keyboard support
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37594/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37594/1//COMMIT_MSG@9
PS1, Line 9: don't
doesn’t
https://review.coreboot.org/c/coreboot/+/37594/1/payloads/libpayload/drivers...
File payloads/libpayload/drivers/i8042/keyboard.c:
https://review.coreboot.org/c/coreboot/+/37594/1/payloads/libpayload/drivers...
PS1, Line 332: if (CONFIG(LP_PC_KEYBOARD_AT_TRANSLATED)) {
How is the Linux kernel able to detect that itself, or initialize all PS/2 keyboards?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1053e24e44c5bad28b56cc92d091e24f3d9b6fd
Gerrit-Change-Number: 37594
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Dec 2019 10:23:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment