Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55796 )
Change subject: soc/amd/non_car/memlayout_x86.ld: Top aling the bootblock
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/common/block/cpu/noncar/memlayout_x86.ld:
https://review.coreboot.org/c/coreboot/+/55796/comment/e1d349b5_24864173
PS1, Line 115: _bootblock
Hrmm, what would it take to use arch/x86/bootblock.ld? It looks like we just need a KCONFIG to remove the .id/.fit pointer
If there is nothing in those sections that should work too, so only conditionally include id.S. Fit has already been moved out.
https://review.coreboot.org/c/coreboot/+/55796/comment/e537ee8f_d98a9597
PS1, Line 124: 64
Why the extra 64?
ALIGN(x) aligns downwards but we are aligning the bootblock to the top, so some extra bytes appended help.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22116bd4b5be86e21cd5a16d6663166a10add17e
Gerrit-Change-Number: 55796
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 22 Mar 2022 12:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment