[coreboot-gerrit] Change in coreboot[master]: sc7180: Add UART support

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35500 )

Change subject: sc7180: Add UART support
......................................................................

Patch Set 39:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35500/39/src/soc/qualcomm/sc7180/qu... 
File src/soc/qualcomm/sc7180/qupv3_uart.c:

https://review.coreboot.org/c/coreboot/+/35500/39/src/soc/qualcomm/sc7180/qu... 
PS39, Line 157: #ifndef __PRE_RAM__
This macro has been removed, so this #ifndef does nothing anymore. Just remove it.

https://review.coreboot.org/c/coreboot/+/35500/39/src/soc/qualcomm/sc7180/qu... 
PS39, Line 165: 	serial.regwidth = 4;
Should add a

serial.input_hertz = QUP_UART_SRC_HZ;

here (QUP_UART_SRC_HZ being 7372800, see comment on other CL).