Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37007 )
Change subject: [TEST]cpu/x86/mp_init: Park APs in C7 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37007/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37007/1//COMMIT_MSG@7 PS1, Line 7: C7 Why not the deepest C-state?
https://review.coreboot.org/c/coreboot/+/37007/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/37007/1/src/cpu/x86/mp_init.c@187 PS1, Line 187: /* need some address of write-back memory, use AP's stack for now */ if we enable PARALLEL_MP_AP_WORK we can use the callback object as the monitor/mwait address to wait.
We should also do the hinting C-state calculation based on msr info, right?