Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration ......................................................................
Patch Set 22:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/52181/comment/8dc3286a_7fa24d46 PS18, Line 10: while
I just accidentally stumbled upon this CL. […]
Reason being that we don't want to force all variants to define the fingerprint present/absent bits in FW_CONFIG even if: a. they do not use fingerprint device at all b. always use fingerprint device
a. is more likely i.e. we will have variants where fingerprint is not used at all. If we use FW_CONFIG to identify this, then we have to define the corresponding bits in FW_CONFIG just to make software happy.
Idea is that: * FW_CONFIG --> controls device on/off status * device status --> determines any action that software takes
With this, we are not forcing every variant to define the same FW_CONFIG bits.
I agree that device lookup is a little more involved right now with the parsing logic, but we should look into extending the aliases to get access to device we care about directly without having to parse the entire tree. But that is a separate problem to solve.