Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36015 )
Change subject: mb/google/octopus: Override VBT selection for Blooguard ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/bloog/variant.c:
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 26: SKU_49_BLOOGUARD = 49, /* kb blit, no USI Stylus */
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 26: SKU_49_BLOOGUARD = 49, /* kb blit, no USI Stylus */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 27: SKU_50_BLOOGUARD = 50, /* kb blit, USI Stylus */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 27: SKU_50_BLOOGUARD = 50, /* kb blit, USI Stylus */
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 28: SKU_51_BLOOGUARD = 51, /* no kb blit, no USI Stylus */
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 28: SKU_51_BLOOGUARD = 51, /* no kb blit, no USI Stylus */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 29: SKU_52_BLOOGUARD = 52, /* no kb blit, USI Stylus */
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/36015/2/src/mainboard/google/octopu... PS2, Line 29: SKU_52_BLOOGUARD = 52, /* no kb blit, USI Stylus */
please, no spaces at the start of a line
Done