Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27810 )
Change subject: util/bincfg: code cleanup: convert sym_table to a local variable
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/27810/6/util/bincfg/bincfg.h
File util/bincfg/bincfg.h:
https://review.coreboot.org/#/c/27810/6/util/bincfg/bincfg.h@39
PS6, Line 39:
: static struct field *putsym(field_ptr_t, char const *, unsigned int);
: static struct field *getsym(field_ptr_t, char const *);
: static void yyerror(FILE *, field_ptr_t, char const *);
this broke bincfg as field_ptr_t is not defined now...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I652a8da75498f871a53eb7509f6145c4842e3373
Gerrit-Change-Number: 27810
Gerrit-PatchSet: 6
Gerrit-Owner: Denis 'GNUtoo' Carikli
GNUtoo@no-log.org
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@no-log.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Kocialkowski
contact@paulk.fr
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 26 Jan 2019 10:02:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment