Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86 ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 118: static int transfer_buffer_valid(struct transfer_info_struct *ptr)
const struct transfer_info_struct *ptr
Done
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 129: #if CONFIG(VBOOT)
I had thought we worked around needing the #if. […]
Ah, thanks. I wasn't aware about DECLARE_REGION in symbols.h.
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 130: struct transfer_info_struct *info = (struct transfer_info_struct *)
const
Done
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl... PS10, Line 158: tse->entry_stamp += psp_ts_table->base_time + base_timestamp;
I think you should probably leave a note that base_timestamp is added here because timestamp_add() s […]
Done