Attention is currently required from: V Sowmya, Rizwan Qureshi, Balaji Manigandan, Krishna P Bhat D, Usha P.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62913 )
Change subject: mb/intel/adlrvp: Set half_populated true for ADL-N
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Agree. Filed crosbug https://partnerissuetracker.corp.google. […]
Thanks!
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62913/comment/521de319_389c087c
PS3, Line 51: BOARD_INTEL_ADLRVP_N_EXT_EC
Why only `BOARD_INTEL_ADLRVP_N_EXT_EC`, and not `BOARD_INTEL_ADLRVP_N`?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecc3018a1ab039990ba47898ff0e0e2ede695cc
Gerrit-Change-Number: 62913
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Thu, 31 Mar 2022 22:22:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Usha P
usha.p@intel.com
Gerrit-MessageType: comment