[coreboot-gerrit] Change in coreboot[master]: mainboard/amd: Add padmelon board code

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )

Change subject: mainboard/amd: Add padmelon board code
......................................................................

Patch Set 1:

(2 comments)
> Patch Set 1:
>
> (5 comments)

Thanks for reviewing it so fast. Unfortunately, I found an introduced bug (was not present on earlier versions) and board currently is not booting, thus this has higher priority. Once I fix this bug I'll go back to your requests.

https://review.coreboot.org/c/coreboot/+/33993/1/src/mainboard/amd/padmelon/... 
File src/mainboard/amd/padmelon/fan_init.c:

https://review.coreboot.org/c/coreboot/+/33993/1/src/mainboard/amd/padmelon/... 
PS1, Line 29: []
> [FINTEK_BOUNDARIES_SIZE]

Will do

https://review.coreboot.org/c/coreboot/+/33993/1/src/mainboard/amd/padmelon/... 
PS1, Line 112: static void init_hwm(void)
> this shouldn't be done here

Agree, that's why I placed the "todo". Working on it.