Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46004 )
Change subject: soc/intel/common/block/acpi: Factor out common pcie_rp_xx_xx.asl
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
IMHO, this would be best done using a SSDT generator for the enabled PCIe ports only.
Yes, totally agree, i will raise a task for internal team to pick and do that going forward. bt i believe for now, this is what look best in terms of reuse of code :) but would be great to generate code based on existing Kconfig option from C code in future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaff9decb63ed88eb64c9e61a57d6adf69a46d3d4
Gerrit-Change-Number: 46004
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sun, 04 Oct 2020 15:31:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment