Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45321 )
Change subject: soc/intel/jasperlake: Clean up iomap.h and systemagent.h
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45321/1/src/soc/intel/jasperlake/in...
File src/soc/intel/jasperlake/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/45321/1/src/soc/intel/jasperlake/in...
PS1, Line 24: 0x6A40
: #define IMRLIMIT
nit: hex in lowercase
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief13406b0116ce0f0b7472e5b133b3fac06f6e27
Gerrit-Change-Number: 45321
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Sun, 13 Sep 2020 15:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment