9 May
2019
9 May
'19
1:43 p.m.
Marius Genheimer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31634 )
Change subject: util/inteltool: Improve GPIO specification ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/31634/10/util/inteltool/gpio_test.h File util/inteltool/gpio_test.h:
https://review.coreboot.org/#/c/31634/10/util/inteltool/gpio_test.h@26 PS10, Line 26: FUNC(3, "ESPI_IO0") } },
I am fine with both.
I'm fine with both display styles as well, but I think in terms of readability the multi-line version has an edge over the single-line approach.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31634
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie92a5af141a907251fc847d53c767984949d9312
Gerrit-Change-Number: 31634
Gerrit-PatchSet: 10
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marius Genheimer mail@f0wl.cc
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 May 2019 20:43:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment