Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40007 )
Change subject: mb/asus/p2b{,-ls}: Get rid of power button device
......................................................................
Patch Set 2:
I looked at the vendor DSDT dump deeper. The flag in question is hardcoded in sb/intel/i82371eb/fadt.c yet matches the value in the vendor dump, yet it also has PWRB. I want to try controlling flag from a config option and flip it for boards that do have PWRB... then again it's just 3 boards in one family and they all have it. Another reason to not proceed with this change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f5b7aaf32366360de3cce58cd742651a2bb46ba
Gerrit-Change-Number: 40007
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Sun, 19 Apr 2020 19:23:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment