Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31640 )
Change subject: mb/google/hatch: Add GPIO programming for GPP_C0 to GPP_C7
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/31640/2/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31640/2/src/mainboard/google/hatch/variants/...
PS2, Line 61: PAD_CFG_GPI(GPP_C6, NONE, DEEP),
This might have to be configured differently depending upon usage. But we can revisit that later.
https://review.coreboot.org/#/c/31640/2/src/mainboard/google/hatch/variants/...
PS2, Line 63: NONE
This will have to be fixed once FSP behavior is fixed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31640
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c6b9310dcc7bade0023abd5524781ce71df28be
Gerrit-Change-Number: 31640
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Feb 2019 14:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment