Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34165 )
Change subject: soc/intel/cnl/graphics: Hook up libgfxinit
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34165/1/src/soc/intel/cannonlake/gr...
File src/soc/intel/cannonlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/34165/1/src/soc/intel/cannonlake/gr...
PS1, Line 58: and input
: * VBT file.
Is this still true?
AFAIK, what could differ?
https://review.coreboot.org/c/coreboot/+/34165/1/src/soc/intel/cannonlake/gr...
PS1, Line 62: .
Minor: I think you can add 'e.g. […]
I really don't care enough about this comment, this is not the
place to document Kconfig options. I merely realigned the code
with its original copy, afair.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34165
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic038adad6cf76867cd4a8626d4c49e17018389fd
Gerrit-Change-Number: 34165
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Comment-Date: Thu, 11 Jul 2019 20:02:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment