Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47956 )
Change subject: fw_config: Default to undefined fw_config value
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c
File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/47956/3/src/lib/fw_config.c@17
PS3, Line 17: ;
Ack
See patchset 5,
Forbidden global variables in romstage:
ffffff00 d fw_config_value.7045
make: *** [src/arch/x86/Makefile.inc:186: coreboot-builds/GOOGLE_VOLTEER2/cbfs/fallback/romstage.debug] Error 1
make: *** Deleting file 'coreboot-builds/GOOGLE_VOLTEER2/cbfs/fallback/romstage.debu
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3046233667e97a5f78961fabacbeb3099b3d442
Gerrit-Change-Number: 47956
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 20:44:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment