[coreboot-gerrit] Change in coreboot[master]: sc7180: Add QUPv3 FW load & config

[Douglas Anderson (Code Review)]

Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35499 )

Change subject: sc7180: Add QUPv3 FW load & config
......................................................................

Patch Set 16: Code-Review-1

(3 comments)

https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... 
File src/soc/qualcomm/sc7180/qupv3_config.c:

https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... 
PS15, Line 20: H1
EC

https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... 
PS15, Line 28: Fingerprint
> EC

Not EC, H1.  Right?

https://review.coreboot.org/c/coreboot/+/35499/15/src/soc/qualcomm/sc7180/qu... 
PS15, Line 32: };
{QUPV3_1_SE5, SE_PROTOCOL_I2C,  MIXED}, /* Codec I2C */