Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33661 )
Change subject: vendorcode/google: load sar config from CBFS first then VPD
......................................................................
Patch Set 1:
In my opinion, having 2 ways of doing things makes it confusing for the partners.
It is impossible to update RO VPD if we did something wrong once it's written.
And there's no reliable way to build a factory "test" for verify the correctness of that value unless if there's some one reviewing that manually.
So if there is only one way, reducing the dependency on factory provisioning would make more sense, i.e., CBFS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33661
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5aa6235fb7a6d0b2ed52893a42f7bd57806af6c1
Gerrit-Change-Number: 33661
Gerrit-PatchSet: 1
Gerrit-Owner: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Wed, 10 Jul 2019 00:31:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment