build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32719 ) Change subject: drivers/apple: Add hybrid graphics driver ...................................................................... Patch Set 3: (7 comments) https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/gm... File src/drivers/apple/hybrid_graphics/gmux.c: https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/gm... PS3, Line 108: const struct drivers_apple_hybrid_graphics_config *config = dev->chip_info; line over 80 characters https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/gm... PS3, Line 109: if (config->gmux_indexed) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/gm... PS3, Line 118: const struct drivers_apple_hybrid_graphics_config *config = dev->chip_info; line over 80 characters https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/gm... PS3, Line 119: if (config->gmux_indexed) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/gm... PS3, Line 128: const struct drivers_apple_hybrid_graphics_config *config = dev->chip_info; line over 80 characters https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/gm... PS3, Line 129: if (config->gmux_indexed) { braces {} are not necessary for any arm of this statement https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/hy... File src/drivers/apple/hybrid_graphics/hybrid_graphics.c: https://review.coreboot.org/#/c/32719/3/src/drivers/apple/hybrid_graphics/hy... PS3, Line 46: brightness = gmux_index_read32(GMUX_PORT_BRIGHTNESS) & GMUX_BRIGHTNESS_MASK; line over 80 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/32719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22b66622cd2da0e9951ee726d650d204fbb8a5bc Gerrit-Change-Number: 32719 Gerrit-PatchSet: 3 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 09 May 2019 23:11:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment