Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )
Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................
Patch Set 24: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/39002/24//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39002/24//COMMIT_MSG@17
PS24, Line 17: of
nit: drop `of`
https://review.coreboot.org/c/coreboot/+/39002/24/src/lib/edid_fill_fb.c
File src/lib/edid_fill_fb.c:
https://review.coreboot.org/c/coreboot/+/39002/24/src/lib/edid_fill_fb.c@70
PS24, Line 70: list_insert_after(&info->node, &list);
Why not insert the new node in `fb_new_framebuffer_info`?
https://review.coreboot.org/c/coreboot/+/39002/24/src/lib/edid_fill_fb.c@77
PS24, Line 77: supports
nit: no `s`: support
https://review.coreboot.org/c/coreboot/+/39002/24/src/mainboard/google/kukui...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39002/24/src/mainboard/google/kukui...
PS24, Line 174: if (info)
Why not:
if (!info)
return false;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7264c2ea2f72f36adfd26f26b00e3ce172133621
Gerrit-Change-Number: 39002
Gerrit-PatchSet: 24
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 20 Oct 2020 17:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment