Attention is currently required from: Frank Wu, John Su, Martin Roth, Furquan Shaikh, Kangheui Won, Isaac Lee, Chris Wang, Rob Barnes, chris wang.
Hello Frank Wu, build bot (Jenkins), Martin Roth, Furquan Shaikh, Kangheui Won, Isaac Lee, Chris Wang, Rob Barnes, chris wang, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/51669
to look at the new patch set (#2).
Change subject: mb/google/zork/vilboz: Adjust eDP PHY driving to improve WWAN noise
......................................................................
mb/google/zork/vilboz: Adjust eDP PHY driving to improve WWAN noise
Only panel swing level = 1 impact WWAN noise, so remove original
settings in device tree. Then we use fw_config to override eDP tuningset
for improve WWAN noise.
BUG=b:171269338
BRANCH=firmware-zork-13434.B
TEST=emerge-zork coreboot chromeos-bootimage
Signed-off-by: John Su john_su@compal.corp-partner.google.com
Change-Id: I8c78c85783d16f3afa1718a3bf41efe9eb121860
---
M src/mainboard/google/zork/variants/baseboard/helpers.c
M src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h
M src/mainboard/google/zork/variants/vilboz/overridetree.cb
M src/mainboard/google/zork/variants/vilboz/variant.c
4 files changed, 28 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/51669/2
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c78c85783d16f3afa1718a3bf41efe9eb121860
Gerrit-Change-Number: 51669
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Isaac Lee
isaaclee@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Isaac Lee
isaaclee@google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-MessageType: newpatchset