Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36057 )
Change subject: src/{device,drivers,mb,nb,soc,sb}: Remove unused 'include <console/console.h>'
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36057/4/src/drivers/vpd/vpd.h
File src/drivers/vpd/vpd.h:
PS4:
unrelated
https://review.coreboot.org/c/coreboot/+/36057/4/src/include/device/dram/com...
File src/include/device/dram/common.h:
https://review.coreboot.org/c/coreboot/+/36057/4/src/include/device/dram/com...
PS4, Line 21: #include <stdint.h>
unrelated
https://review.coreboot.org/c/coreboot/+/36057/4/src/include/device/dram/com...
PS4, Line 58: printk
isn't this defined in console/console.h?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c965e598e260ff8129aa07fb9fc5bf6e784e1d8
Gerrit-Change-Number: 36057
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 20 Oct 2019 16:04:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment