Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25345 )
Change subject: soc/amd/stoneyridge: Generate SPCR table
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/25345/6/src/soc/amd/stoneyridge/uart.c
File src/soc/amd/stoneyridge/uart.c:
https://review.coreboot.org/#/c/25345/6/src/soc/amd/stoneyridge/uart.c@41
PS6, Line 41: AMDCZ
thanks
Why do we need to use the special IDs?
I was able to use a serial bios with the following command line to get earlycon working: earlycon=uart,mmio32,0xfedc6000 console=
By not setting the baudrate in the command line, the kernel driver will assume the correct baud rate has been set.
We could also set the Baud Rate to 0 in the SPCR table, and avoid having to use a custom kernel driver to set the uartclk. See https://docs.microsoft.com/en-us/windows-hardware/drivers/serports/serial-po...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc98bcf4f8c070b8002bcc795254b19f928c741b
Gerrit-Change-Number: 25345
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Mon, 24 Jun 2019 21:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Gerrit-MessageType: comment