Julius Werner has posted comments on this change. ( https://review.coreboot.org/27478 )
Change subject: libpayload/xhci: Check noop return code when debugging ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27478/1/payloads/libpayload/drivers/usb/xhci... File payloads/libpayload/drivers/usb/xhci.c:
https://review.coreboot.org/#/c/27478/1/payloads/libpayload/drivers/usb/xhci... PS1, Line 411: fatal("noop command failed.\n"); I'm not sure die() is the right move here. This is just a debugging feature anyway, it shouldn't matter for production firmware. For debugging on early bring-up boards, I've seen plenty of cases where there was some kind of error here but the system was still usable afterwards (e.g. in case you didn't want to boot from USB, or if only one of several USB controllers was broken somehow). I'm fine with adding the condition code to the message if you want, but I don't think it should hang.