Attention is currently required from: Raul Rangel, Martin Roth, Marshall Dawson, Julian Schroeder. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52909 )
Change subject: src/vendorcode/amd/fsp/cezanne/FspmUpd.h: match amd-fsp ......................................................................
Patch Set 1:
(2 comments)
File src/vendorcode/amd/fsp/cezanne/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52909/comment/785ba58a_37423a37 PS1, Line 110: /** Offset 0x04D7**/ uint8_t sh_oem_usb_config[100];
The AGESA people changed the whole USB setup plumbing. […]
ah, ok. adding and using the struct definition in coreboot sounds like a good idea then. if the usb-related upds above won't be used, they should be removed on both sides; i'm ok if that's done in some follow-up
https://review.coreboot.org/c/coreboot/+/52909/comment/60baf7f1_98847f24 PS1, Line 110: sh_oem
The next patches are going to clean this up. This is really just temporary. […]
i only knew how this was done on picasso and seeing this 100 byte array just looked odd. having this 100 byte array and some header file that defines the matching struct seems to be the best way to go here from what i've seen so far. beware of possible issues due to how the bytes get packed into the struct though