Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32350 )
Change subject: Add support for low power idle table ......................................................................
Patch Set 1:
(6 comments)
This change is ready for review.
https://review.coreboot.org/#/c/32350/1/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/32350/1/src/arch/x86/acpi.c@1146 PS1, Line 1146: lpit->lpit_native.residency=0;
spaces required around that '=' (ctx:VxV)
Ack
https://review.coreboot.org/#/c/32350/1/src/arch/x86/acpi.c@1147 PS1, Line 1147: lpit->lpit_native.latency=0;
please, no spaces at the start of a line
Ack
https://review.coreboot.org/#/c/32350/1/src/arch/x86/acpi.c@1147 PS1, Line 1147: lpit->lpit_native.latency=0;
code indent should use tabs where possible
Ack
https://review.coreboot.org/#/c/32350/1/src/arch/x86/acpi.c@1147 PS1, Line 1147: lpit->lpit_native.latency=0;
spaces required around that '=' (ctx:VxV)
Ack
https://review.coreboot.org/#/c/32350/1/src/arch/x86/acpi.c@1149 PS1, Line 1149: lpit->lpit_native.counter_frequency=0;
spaces required around that '=' (ctx:VxV)
Ack
https://review.coreboot.org/#/c/32350/1/src/arch/x86/include/arch/acpi.h File src/arch/x86/include/arch/acpi.h:
https://review.coreboot.org/#/c/32350/1/src/arch/x86/include/arch/acpi.h@277 PS1, Line 277: }__packed acpi_lpit_header;
space required after that close brace '}'
Ack