4 Oct
2018
4 Oct
'18
7:54 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28724 )
Change subject: commonlib/region: Add region protect API ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/28724/4/src/commonlib/include/commonlib/regi... File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/#/c/28724/4/src/commonlib/include/commonlib/regi... PS4, Line 97: int (*protect)(const struct region *); function definition argument 'const struct region *' should also have an identifier name
--
To view, visit https://review.coreboot.org/28724
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9376e2c2c7a4852f13c65824c6cd64a1c6ac0a
Gerrit-Change-Number: 28724
Gerrit-PatchSet: 4
Gerrit-Owner: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 04 Oct 2018 14:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No