Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules ......................................................................
Patch Set 10:
(8 comments)
https://review.coreboot.org/c/coreboot/+/41719/10/src/cpu/amd/pi/00730F01/up... File src/cpu/amd/pi/00730F01/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/cpu/amd/pi/00730F01/up... PS10, Line 24: u8 i;
unrelated? i'd also rather use size_t here. […]
I think this entire file should be unrelated. Hopefully it was included by accident.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... File src/soc/amd/picasso/microcode_picasso.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 31: remove extra blank line
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 39: /* apply patch */
move this comment right before the wrmsr(MSR_PATCH_LOADER, msr); call? at least that's where the uco […]
I think the source is OK without the comment.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 41: 0xFFFFFFFF If you use lower case here, it'll match coreboot better than AMD's style.
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 57: remove extra space
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 68: uint32_t uintptr_t
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/microc... PS10, Line 68: F17H_MPB_MAX_SIZE still need to remove the F17h stuff
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/update... File src/soc/amd/picasso/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/41719/10/src/soc/amd/picasso/update... PS10, Line 36: u16 It seems like most of the patch use uintnn_t instead of unn. I'd try to make then all similar, or at least match within the same file.