Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59229 )
Change subject: Documentation: Remove references to "private" changes on Gerrit ......................................................................
Documentation: Remove references to "private" changes on Gerrit
Private changes on Gerrit are a tricky beast in that they're well hidden in the UI and a few other places but still reachable with little effort when you want to dig for private changes.
Therefore review.coreboot.org disabled that feature, so update the documentation to follow.
Change-Id: I1c8c6cccfd023bc1d839dc5d9544204c88f89c7e Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/getting_started/gerrit_guidelines.md M Documentation/tutorial/part2.md 2 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/59229/1
diff --git a/Documentation/getting_started/gerrit_guidelines.md b/Documentation/getting_started/gerrit_guidelines.md index 8c91615..6a5ba37 100644 --- a/Documentation/getting_started/gerrit_guidelines.md +++ b/Documentation/getting_started/gerrit_guidelines.md @@ -191,14 +191,10 @@ git push origin HEAD:refs/for/master%wip
* When pushing patches that are not for submission, these should be marked -as such. This can be done in the title ‘[DONOTSUBMIT]’, or can be pushed as -private changes, so that only explicitly added reviewers will see them. These -sorts of patches are frequently posted as ideas or RFCs for the community -to look at. To push a private change, use the command: - git push origin HEAD:refs/for/master%private +as such. This can be done in the title ‘[DONOTSUBMIT]’ or by pushing as WIP.
* Multiple push options can be combined: - git push origin HEAD:refs/for/master%private,wip,topic=experiment + git push origin HEAD:refs/for/master%wip,topic=experiment
* Respond to anyone who has taken the time to review your patches, even if it's just to say that you disagree. While it may seem annoying to address a diff --git a/Documentation/tutorial/part2.md b/Documentation/tutorial/part2.md index 4ac8574..693e36b 100644 --- a/Documentation/tutorial/part2.md +++ b/Documentation/tutorial/part2.md @@ -170,10 +170,7 @@ you to take back your commit and amend it.
When you are done with your commit, run `git push` to push your commit to -coreboot.org. **Note:** To submit as a private patch, use -`git push origin HEAD:refs/for/master%private`. Submitting as a private patch -means that your commit will be on review.coreboot.org, but is only visible to -yourself and those you add as reviewers. +coreboot.org.
This has been a quick primer on how to submit a change to Gerrit for review using git. You may wish to review the [Gerrit code review workflow